Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Test fix 4.36.2 #127

Closed
wants to merge 3 commits into from
Closed

Test fix 4.36.2 #127

wants to merge 3 commits into from

Conversation

nickdickinson
Copy link
Collaborator

Fixing database user tests to accept newly added fields when comparing snapshots.

@nickdickinson nickdickinson requested a review from akbertram July 2, 2024 15:26
akbertram
akbertram requested changes Jul 3, 2024
View reviewed changes
Copy link
Member

@akbertram akbertram left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actually, since there is no change to the functionality, I'd prefer to merge in the fix without bumping the version or doing another release. Will do so now and close this PR

@akbertram akbertram closed this Jul 3, 2024
@akbertram
Copy link
Member

Merged!

@nickdickinson nickdickinson mentioned this pull request Jul 12, 2024
Closed
@jamiewhths jamiewhths deleted the test-fix-4.36.2 branch September 23, 2024 11:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@akbertram akbertram akbertram requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nickdickinson @akbertram