Update package build configuration to include missing dependencies #33
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## master #33 +/- ##
=======================================
Coverage 89.23% 89.23%
=======================================
Files 27 27
Lines 3548 3548
=======================================
Hits 3166 3166
Misses 382 382
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
ir4y
reviewed
Feb 5, 2024
pyproject.toml
Outdated
| @@ -37,7 +37,7 @@ license = { file = "LICENSE.md" } | |||
| keywords = ["fhir", "fhirpath"] | |||
| dynamic = ["version"] | |||
| authors = [{ name = "beda.software", email = "[email protected]" }] | |||
| dependencies = ["antlr4-python3-runtime~=4.10"] | |||
| dependencies = ["antlr4-python3-runtime~=4.10", "python-dateutil==2.8.2"] | |||
There was a problem hiding this comment.
Can we use python-dateutil~=2.8.2 to not stick with a specific version of python-dateutil @m0rl ?
There was a problem hiding this comment.
Sure, updated the PR to use compatible releases instead.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fhirpathpy package installed into a virtualenv fails to run
evaluateraising