-
-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
API extension for Support for Retsynth #63
Draft
rkrishnasanka
wants to merge
31
commits into
bebop:dev
Choose a base branch
from
UppBio:feature/retsynth-api
base: dev
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* renamed pkg/insert to pkg/init. * add CreateTestDB function for init package. * backing up and checking out new branch. * added personal fork of surrealdb driver to go.mod and go.sum. * added config to use surrealdb websocket default url. * added config defaults for admin user and password. * added DB name to config. * insert, upsert, and retrieval working for genbank. * got basic uniprot insert working. * updated testdev config db namespace to allbaseTest * CreateTestDB now clobbers old testdbs. * changed create to upsert like logic. * got compound insertion for rhea working. * commented out and added TODOs for things that cause tests to fail. Will add issues.
…rresponding queries. TODO: 1. Update with the sql queries with the builder API queries 2. Add the GraphQL structures 3. Add the testcases for `queries.go`
TODO: - There's a need to collapse all the queries for specific types of queries. Perhaps do this once the datamodels have been joined together. - We can reduce the number of potential bugs for mistyping, we need to tie in the types for all the subfields away from base types. It's necessary to wrapper these datafields to have the static type safety in the long run
TODO: - Refactor VCS to be more of an object like so that we can reduce dependenies . - Create workthrough tests to make sure we are able to do - Flesh out the full extent of the retsynth tests now that we have the minimal database
TODO: Need to update this with the more specific API calls as needed by RetSynth.
…phql files for both a retsynth specific API to use as a stand-in replacement with the current public version of retsynth. Additionally started creating the synbiodb.graphql that should be the convergence API
…ng project - Added and ran the baseline gqlgen package and generated the implementations - Need to figure out how to have multiple graphql schemas and have separate resolvers for them
…es. Additionally, this is the first prototype of the graphql engine
Baseline querying works for the organisms and compounds API
- Cleaned up resolver code - Moved the server start code into main.go - Updated the makefile with clean, run playground and build functions that chain
- Moved all the parameters into the `parameters` package
…reduces the overall code repeat.
Currently working on the rest of the test cases.
…ests to verify if the sql is correct.
… for a large subset of queries. These are unresolved problems.
…ly assumed that they would just return None types / nil values
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a draft pull request for an API integration that adds support for retsynth data dumps. This PR reflects the baseline support for incorporating
allbase
within Upp BioTODO:
allbase
data models