Server side caching #193

drakos74 · 2020-03-30T07:34:44Z

Description

Create server side http cache, closes #128.

Changes

use cache interface of patron
create server side cache
accept client control headers
make the cache part of the route building logic
abstract cache for both RouteBuilder and RawRouteBuilder

codecov · 2020-04-03T07:39:26Z

Codecov Report

Merging #193 into master will increase coverage by 0.11%.
The diff coverage is 75.66%.

@@            Coverage Diff             @@
##           master     #193      +/-   ##
==========================================
+ Coverage   73.07%   73.19%   +0.11%     
==========================================
  Files          57       61       +4     
  Lines        3332     3652     +320     
==========================================
+ Hits         2435     2673     +238     
- Misses        835      904      +69     
- Partials       62       75      +13

Impacted Files	Coverage Δ
component/http/cache/route.go	`49.20% <49.20%> (ø)`
component/http/cache/metric.go	`63.33% <63.33%> (ø)`
component/http/middleware.go	`90.83% <70.00%> (-1.90%)`	⬇️
component/http/cache/cache.go	`81.96% <81.96%> (ø)`
component/http/cache/model.go	`90.90% <90.90%> (ø)`
component/http/handler.go	`98.05% <90.90%> (+0.01%)`	⬆️
component/http/http.go	`100.00% <100.00%> (ø)`
component/http/route.go	`100.00% <100.00%> (ø)`
component/async/kafka/simple/duration_client.go	`93.75% <0.00%> (-3.13%)`	⬇️
... and 4 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f8ebb41...6b3f075. Read the comment docs.

Signed-off-by: Vangelis Katikaridis <[email protected]>

mantzas

The changes are a lot and we probably need more than one session the review this.

component/http/cache.go

component/http/cache_builder.go

component/http/cache_builder_test.go

component/http/cache_metrics.go

component/http/component.go

component/http/route_cache_test.go

component/http/route_cache.go

component/http/cache_metrics.go

README.md

component/http/cache.go

component/http/cache_builder.go

component/http/cache.go

mantzas

Since we have examples in this project it would be nice to see how the end-user will actually use the cache introduced.

component/http/route.go

component/http/cache_builder.go

component/http/http.go

Signed-off-by: Vangelis Katikaridis <[email protected]>

Signed-off-by: Stanislav Afanasev <[email protected]>

Signed-off-by: Giuseppe Mazzotta <[email protected]>

Signed-off-by: Vangelis Katikaridis <[email protected]>

tpaschalis

Some really great work mate, I'm on my second pass-through to really understand how it's all pieced together but 🚀

Since it already has one approval, and I don't think I'll have much to add, do you mind rebasing with master?

README.md

Signed-off-by: Vangelis Katikaridis <[email protected]>

mantzas

There are linting errors, can you fix them?

Signed-off-by: Vangelis Katikaridis <[email protected]>

tpaschalis

LGTM!

* beatlabs#128 cache wip implementation Signed-off-by: Vangelis Katikaridis <[email protected]> * beatlabs#128 adjust to patron new version Signed-off-by: Vangelis Katikaridis <[email protected]> * beatlabs#128 refine requirements Signed-off-by: Vangelis Katikaridis <[email protected]> * beatlabs#128 first iteration of server cache functionality Signed-off-by: Vangelis Katikaridis <[email protected]> * beatlabs#128 server route cache implementation Signed-off-by: Vangelis Katikaridis <[email protected]> * Add validation for brokers in kafka.NewBuilder (beatlabs#191) Signed-off-by: Stanislav Afanasev <[email protected]> * Add ActiveBrokers() method to Kafka AsyncProducer (beatlabs#192) Signed-off-by: Giuseppe Mazzotta <[email protected]> * beatlabs#128 revert sixth example main Signed-off-by: Vangelis Katikaridis <[email protected]> * beatlabs#128 update readme Signed-off-by: Vangelis Katikaridis <[email protected]> * beatlabs#128 fix linting Signed-off-by: Vangelis Katikaridis <[email protected]> * beatlabs#128 fix more linting Signed-off-by: Vangelis Katikaridis <[email protected]> * beatlabs#128 fix tests Signed-off-by: Vangelis Katikaridis <[email protected]> * beatlabs#128 fix tests Signed-off-by: Vangelis Katikaridis <[email protected]> * beatlabs#128 add vendor file Signed-off-by: Vangelis Katikaridis <[email protected]> * Add Route struct getters (beatlabs#195) Signed-off-by: Alex Demin <[email protected]> * Introduce dockertest to integration tests (beatlabs#182) Signed-off-by: Vangelis Katikaridis <[email protected]> * beatlabs#128 wrap up implementation Signed-off-by: Vangelis Katikaridis <[email protected]> * beatlabs#128 fix tests Signed-off-by: Vangelis Katikaridis <[email protected]> * beatlabs#128 add readme details on cache metrics Signed-off-by: Vangelis Katikaridis <[email protected]> * beatlabs#128 readme adjustments Signed-off-by: Vangelis Katikaridis <[email protected]> * beatlabs#128 finalise implementation Signed-off-by: Vangelis Katikaridis <[email protected]> * beatlabs#128 increase test timeout Signed-off-by: Vangelis Katikaridis <[email protected]> * beatlabs#128 decouple tests Signed-off-by: Vangelis Katikaridis <[email protected]> * beatlabs#128 fix tests Signed-off-by: Vangelis Katikaridis <[email protected]> * beatlabs#193 fix tests Signed-off-by: Vangelis Katikaridis <[email protected]> * Update tracing and metrics dependencies (beatlabs#190) Signed-off-by: Paschalis Tsilias <[email protected]> * beatlabs#128 implement review comments Signed-off-by: Vangelis Katikaridis <[email protected]> * beatlabs#128 implement review comments Signed-off-by: Vangelis Katikaridis <[email protected]> * beatlabs#128 fix linting Signed-off-by: Vangelis Katikaridis <[email protected]> * beatlabs#128 update vendors Signed-off-by: Vangelis Katikaridis <[email protected]> * beatlabs#128 implement review comments Signed-off-by: Vangelis Katikaridis <[email protected]> * beatlabs#128 implement review comments Signed-off-by: Vangelis Katikaridis <[email protected]> * beatlabs#128 implement review comments Signed-off-by: Vangelis Katikaridis <[email protected]> * beatlabs#128 implement review comments Signed-off-by: Vangelis Katikaridis <[email protected]> * Upgraded github actions v2 (beatlabs#198) Signed-off-by: Sotirios Mantziaris <[email protected]> * beatlabs#128 make abstraction simpler and easier to use Signed-off-by: Vangelis Katikaridis <[email protected]> * beatlabs#128 add comment Signed-off-by: Vangelis Katikaridis <[email protected]> * beatlabs#128 fix linting Signed-off-by: Vangelis Katikaridis <[email protected]> * beatlabs#128 trigger the build Signed-off-by: Vangelis Katikaridis <[email protected]> * beatlabs#128 unexport response read writer Signed-off-by: Vangelis Katikaridis <[email protected]> * beatlabs#128 check for min < max Signed-off-by: Vangelis Katikaridis <[email protected]> * beatlabs#128 update vendor Signed-off-by: Vangelis Katikaridis <[email protected]> * beatlabs#128 remove timeinstant and make use of ttl cache only for route caching Signed-off-by: Vangelis Katikaridis <[email protected]> * beatlabs#128 update readme after latest changes Signed-off-by: Vangelis Katikaridis <[email protected]> * beatlabs#128 fix redis cache interaction and create cached route example Signed-off-by: Vangelis Katikaridis <[email protected]> * beatlabs#128 remove the processor specific logic for the cache Signed-off-by: Vangelis Katikaridis <[email protected]> * beatlabs#128 use the patron header alias instead of a raw map Signed-off-by: Vangelis Katikaridis <[email protected]> * beatlabs#128 fix linting Signed-off-by: Vangelis Katikaridis <[email protected]> * beatlabs#128 expose cache functionality as a middleware Signed-off-by: Vangelis Katikaridis <[email protected]> * beatlabs#128 fix linting Signed-off-by: Vangelis Katikaridis <[email protected]> * beatlabs#128 refactor cache logic to separate package Signed-off-by: Vangelis Katikaridis <[email protected]> * beatlabs#128 remove timeinstant abstraction Signed-off-by: Vangelis Katikaridis <[email protected]> * beatlabs#128 avoid defining the prometheus registerer Signed-off-by: Vangelis Katikaridis <[email protected]> * beatlabs#128 fix linting and exported objects Signed-off-by: Vangelis Katikaridis <[email protected]> * beatlabs#128 make middleware cache abstraction more concrete Signed-off-by: Vangelis Katikaridis <[email protected]> * beatlabs#128 make the naming conventions and structure more go like Signed-off-by: Vangelis Katikaridis <[email protected]> * beatlabs#128 fix imports Signed-off-by: Vangelis Katikaridis <[email protected]> * beatlabs#128 move timing request example to user service Signed-off-by: Vangelis Katikaridis <[email protected]> * beatlabs#128 fix typo Signed-off-by: Vangelis Katikaridis <[email protected]> * beatlabs#128 add package doc Signed-off-by: Vangelis Katikaridis <[email protected]> Co-authored-by: Stanislav Afanasev <[email protected]> Co-authored-by: Giuseppe <[email protected]> Co-authored-by: Alexander Demin <[email protected]> Co-authored-by: Paschalis Tsilias <[email protected]> Co-authored-by: Sotirios Mantziaris <[email protected]>

drakos74 requested review from cpapidas, fpapadopou, mantzas, moukoublen and sotirispl as code owners March 30, 2020 07:34

drakos74 force-pushed the server-side-caching branch from 41986a3 to 7a37628 Compare April 1, 2020 16:27

drakos74 changed the title ~~WIP Server side caching~~ Server side caching Apr 4, 2020

drakos74 added a commit to drakos74/patron that referenced this pull request Apr 6, 2020

beatlabs#193 fix tests

7aa3d9a

Signed-off-by: Vangelis Katikaridis <[email protected]>

mantzas requested changes Apr 8, 2020

View reviewed changes

drakos74 requested a review from mantzas April 9, 2020 09:17

mantzas requested changes Apr 12, 2020

View reviewed changes

fpapadopou suggested changes Apr 15, 2020

View reviewed changes

component/http/cache.go Outdated Show resolved Hide resolved

drakos74 requested review from fpapadopou and mantzas April 15, 2020 13:13

drakos74 commented Apr 23, 2020

View reviewed changes

component/http/cache.go Outdated Show resolved Hide resolved

drakos74 commented Apr 23, 2020

View reviewed changes

component/http/cache.go Outdated Show resolved Hide resolved

drakos74 commented Apr 23, 2020

View reviewed changes

component/http/cache.go Outdated Show resolved Hide resolved

mantzas requested changes May 2, 2020

View reviewed changes

component/http/route.go Outdated Show resolved Hide resolved

component/http/cache_builder.go Outdated Show resolved Hide resolved

component/http/cache_builder.go Outdated Show resolved Hide resolved

component/http/http.go Outdated Show resolved Hide resolved

drakos74 and others added 11 commits May 2, 2020 10:01

beatlabs#128 cache wip implementation

d5a429c

Signed-off-by: Vangelis Katikaridis <[email protected]>

beatlabs#128 adjust to patron new version

af77c43

Signed-off-by: Vangelis Katikaridis <[email protected]>

beatlabs#128 refine requirements

9115ffb

Signed-off-by: Vangelis Katikaridis <[email protected]>

beatlabs#128 first iteration of server cache functionality

cb572cf

Signed-off-by: Vangelis Katikaridis <[email protected]>

beatlabs#128 server route cache implementation

784cf71

Signed-off-by: Vangelis Katikaridis <[email protected]>

Add validation for brokers in kafka.NewBuilder (beatlabs#191)

8bf60d7

Signed-off-by: Stanislav Afanasev <[email protected]>

Add ActiveBrokers() method to Kafka AsyncProducer (beatlabs#192)

4c3cbc0

Signed-off-by: Giuseppe Mazzotta <[email protected]>

beatlabs#128 revert sixth example main

42c23b5

Signed-off-by: Vangelis Katikaridis <[email protected]>

beatlabs#128 update readme

a3a1784

Signed-off-by: Vangelis Katikaridis <[email protected]>

beatlabs#128 fix linting

88cf1a2

Signed-off-by: Vangelis Katikaridis <[email protected]>

beatlabs#128 fix more linting

2daa01b

Signed-off-by: Vangelis Katikaridis <[email protected]>

drakos74 added 3 commits May 9, 2020 13:15

beatlabs#128 make the naming conventions and structure more go like

64edaa4

Signed-off-by: Vangelis Katikaridis <[email protected]>

beatlabs#128 fix imports

48211a7

Signed-off-by: Vangelis Katikaridis <[email protected]>

beatlabs#128 move timing request example to user service

18c447d

Signed-off-by: Vangelis Katikaridis <[email protected]>

drakos74 requested a review from mantzas May 9, 2020 15:53

mantzas previously approved these changes May 14, 2020

View reviewed changes

drakos74 and others added 4 commits May 15, 2020 19:26

Merge branch 'master' into server-side-caching

c8f4994

Merge branch 'master' into server-side-caching

ded88e6

Merge branch 'master' into server-side-caching

a6e1b61

Merge branch 'master' into server-side-caching

83d9a92

tpaschalis requested review from tpaschalis and removed request for moukoublen July 10, 2020 19:39

tpaschalis previously approved these changes Jul 10, 2020

View reviewed changes

README.md Outdated Show resolved Hide resolved

mantzas removed request for cpapidas, sotirispl and fpapadopou July 12, 2020 06:33

drakos74 and others added 2 commits July 22, 2020 17:29

Merge branch 'master' into server-side-caching

e3dcaa2

beatlabs#128 fix typo

da3698c

Signed-off-by: Vangelis Katikaridis <[email protected]>

drakos74 dismissed stale reviews from tpaschalis and mantzas via da3698c July 22, 2020 15:32

drakos74 requested review from mantzas and tpaschalis July 22, 2020 15:32

Merge branch 'master' into server-side-caching

f2470c8

mantzas reviewed Jul 23, 2020

View reviewed changes

beatlabs#128 add package doc

6b3f075

Signed-off-by: Vangelis Katikaridis <[email protected]>

drakos74 requested a review from mantzas July 24, 2020 07:22

mantzas approved these changes Jul 24, 2020

View reviewed changes

tpaschalis approved these changes Jul 24, 2020

View reviewed changes

drakos74 merged commit 7471d01 into beatlabs:master Jul 24, 2020

drakos74 deleted the server-side-caching branch July 24, 2020 08:09

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Server side caching #193

Server side caching #193

drakos74 commented Mar 30, 2020 •

edited by mantzas

Loading

codecov bot commented Apr 3, 2020 •

edited

Loading

mantzas left a comment

mantzas left a comment

tpaschalis left a comment

mantzas left a comment

tpaschalis left a comment

Server side caching #193

Server side caching #193

Conversation

drakos74 commented Mar 30, 2020 • edited by mantzas Loading

codecov bot commented Apr 3, 2020 • edited Loading

Codecov Report

mantzas left a comment

Choose a reason for hiding this comment

mantzas left a comment

Choose a reason for hiding this comment

tpaschalis left a comment

Choose a reason for hiding this comment

mantzas left a comment

Choose a reason for hiding this comment

tpaschalis left a comment

Choose a reason for hiding this comment

drakos74 commented Mar 30, 2020 •

edited by mantzas

Loading

codecov bot commented Apr 3, 2020 •

edited

Loading