Fixed HTTP metrics bug

Signed-off-by: Sotirios Mantziaris <[email protected]>

sync/http/middleware.go

@@ -105,7 +105,7 @@ func NewTracingMiddleware(path string) MiddlewareFunc {
 		return http.HandlerFunc(func(w http.ResponseWriter, r *http.Request) {
 			sp, r := trace.HTTPSpan(path, r)
 			lw := newResponseWriter(w)
-			next.ServeHTTP(w, r)
+			next.ServeHTTP(lw, r)
 			trace.FinishHTTPSpan(sp, lw.Status())
 		})
 	}

trace/trace.go

@@ -91,6 +91,7 @@ func HTTPSpan(path string, r *http.Request) (opentracing.Span, *http.Request) {
 // FinishHTTPSpan finishes a HTTP span by providing a HTTP status code.
 func FinishHTTPSpan(sp opentracing.Span, code int) {
 	ext.HTTPStatusCode.Set(sp, uint16(code))
+	ext.Error.Set(sp, code >= http.StatusInternalServerError)
 	sp.Finish()
 }
 

trace/trace_test.go

@@ -94,6 +94,7 @@ func TestHTTPStartFinishSpan(t *testing.T) {
 	assert.Equal(t, map[string]interface{}{
 		"span.kind":        ext.SpanKindRPCServerEnum,
 		"component":        "http",
+		"error":            false,
 		"http.method":      "GET",
 		"http.status_code": uint16(200),
 		"http.url":         "/",