Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

possible mobile design #57

Merged
merged 3 commits into from
Feb 1, 2024
Merged

possible mobile design #57

merged 3 commits into from
Feb 1, 2024

Conversation

rfairooz
Copy link
Collaborator

@rfairooz rfairooz commented Jan 25, 2024

Screenshot 2024-01-31 at 6 56 03 PM Screenshot 2024-01-31 at 6 56 11 PM

@rfairooz rfairooz self-assigned this Jan 25, 2024
Copy link
Contributor

@NovaSagittarii NovaSagittarii left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! The background gradient appears nicely with the glow effect on the buttons. For future reference, you can use CSS transformations scaleX(-1) to horizontally flip an asset instead of including an entirely new asset. It is fine in this case since it's a one-off and the file itself isn't too large.

@menthy-wu
Copy link
Contributor

The assets looks so nice, but the box and the black background looks a bit weird

@rfairooz
Copy link
Collaborator Author

rfairooz commented Feb 1, 2024

Looks good! The background gradient appears nicely with the glow effect on the buttons. For future reference, you can use CSS transformations scaleX(-1) to horizontally flip an asset instead of including an entirely new asset. It is fine in this case since it's a one-off and the file itself isn't too large.

So I changed it a bit more and the new picture is what it looks like right now

@rfairooz
Copy link
Collaborator Author

rfairooz commented Feb 1, 2024

The assets looks so nice, but the box and the black background looks a bit weird

yes can you check the new look of it? I updated the pictures

@rfairooz rfairooz merged commit c376431 into dev Feb 1, 2024
7 checks passed
@rfairooz rfairooz deleted the raidah/mobile branch February 1, 2024 05:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants