Restore admin dashboard styles #52
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
too unpredictable if the entire admin dashboard is turned dark mode
mr-4 on checkbox previoy did this
rfairooz
approved these changes
Jan 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #50
Previous styling changes which were meant for the forms now only apply to the forms with the
customStyleprop which must be opted into for the style changes to apply. This was done since the dark mode forms are really incompatible with the light mode admin dashboard, which also has a lot of hardcoded light mode styles.A more robust solution would be to replace all the hardcoded tailwind colors with references to hackathon tailwind theme colors (such as how
bg-hackathon-pageis used instead of using something likebg-white), but this involves changing many files and would lead to many future merge conflicts (whenever any classList gets modified in the template).