New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add light/dark mode switch (#1874) #1883

Closed

nerd4me wants to merge 0 commits into beancount:main from nerd4me:main

nerd4me commented Oct 27, 2024

add light/dark mode switch (#1874)

Member

yagebu commented Dec 9, 2024

Hi, thanks for creating this PR. There's some problems I see with this current approach:

I think the screen space in the header is too valuable for this sort of infrequently used toggle. I think putting it on the options page would be better.
The default shouldn't be dark but whatever the system default is. So there would need to be three toggle options. AFAICT there's no good way to implement this without having to duplicate all the styles... Generally, I guess it's annoying that this is not simply a browser feature...

One other point: Did you create those images yourself?

nerd4me closed this

nerd4me force-pushed the main branch from 5630ca4 to 2261c27 Compare

January 2, 2025 03:27

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet