Modified dietz returns #28
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I fixed most 'problems', like os calls instead of pathlib, some type hints that were wrong and formatted the code using ruff. This commit could be ignored without problems, as it doesn't have any functional change.
|
Hey! Is there any path forward for this PR? |
|
You'll have to wait
Busy life
…On Fri, Jun 7, 2024, 11:57 Franco Calvo ***@***.***> wrote:
Hey! Is there any path forward for this PR?
—
Reply to this email directly, view it on GitHub
<#28 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AACSBEYIL42DOCMDJ5XW2EDZGHJ6BAVCNFSM6AAAAABIRWOME2VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDCNJVGEYTKNJRHA>
.
You are receiving this because you are subscribed to this thread.Message
ID: ***@***.***>
|
|
Nice work, thanks for modernizing the codebase. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is what we talked in issue #27.
It also would allow to close #19.
New table would look like this:
I'm using @andreasgerstmayr example config from fava-portfolio-returns.
Also, I'd encourage merging PR #22 if it doesn't break anything. Currently, I have to execute beangrow using
PROTOCOL_BUFFERS_PYTHON_IMPLEMENTATION=python.