Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🚚 Migrating greater than matcher #72

Merged
merged 5 commits into from
Dec 28, 2022
Merged

🚚 Migrating greater than matcher #72

merged 5 commits into from
Dec 28, 2022

Conversation

tamar-ot
Copy link

@tamar-ot tamar-ot commented Dec 27, 2022 •
edited by bdsoha
Loading

Closes #51, closes #50

Before submitting this PR, please make sure:

  • My code follows the style guidelines of this project
  • Your code builds clean without any errors or warnings
  • You are using approved terminology
  • You have added unit tests

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

@tamar-ot tamar-ot requested a review from bdsoha as a code owner December 27, 2022 06:39
@tamar-ot
Copy link
Author

adding great than matcher and tests

bdsoha
bdsoha requested changes Dec 27, 2022
View reviewed changes
Copy link
Owner

@bdsoha bdsoha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please remove the old tests from test/expect_to_test_suite.py, test/expect_to_not_test_suite.py and their related stubs.

@bdsoha bdsoha added this to the 🏗️ v1.0.0 - Core Rewrite milestone Dec 27, 2022
This was linked to issues Dec 27, 2022
Rewrite greater_than_or_equal as matcher #50
Closed
Rewrite greater_than as matcher #51
Closed
@bdsoha bdsoha merged commit 87485e6 into bdsoha:v1.0.0-next Dec 28, 2022
@boring-cyborg
Copy link

boring-cyborg bot commented Dec 28, 2022

🎉 ⭐ ✨ Awesome work, congrats on your first merged pull request!

@bdsoha bdsoha changed the title Great than matcher and tests 🚚 Migrating greater than matcher Jan 10, 2023
@tamar-ot tamar-ot deleted the great_than branch January 13, 2023 05:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bdsoha bdsoha bdsoha requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
🏗️ v1.0.0 - Core Rewrite
Development

Successfully merging this pull request may close these issues.

Rewrite greater_than as matcher Rewrite greater_than_or_equal as matcher
2 participants
@tamar-ot @bdsoha