Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rewrite core internals #28

Open
17 of 19 tasks
bdsoha opened this issue Dec 8, 2022 · 0 comments
Open
17 of 19 tasks

Rewrite core internals #28

bdsoha opened this issue Dec 8, 2022 · 0 comments
Labels
✨ enhancement New feature or request

Comments

@bdsoha
Copy link
Owner

bdsoha commented Dec 8, 2022

Rewrite core internals in a more object oriented fashion.

  • Move the responsibility for evaluating (comparing actual and expected) from BaseExpectation to a new base class
class BaseMatcher:
    def message(self, *, actual=None, **kwargs) -> str:
        ...

    def _match(self, *, actual=None, **kwargs):
        ...

    def _negate(self, *, actual=None, **kwargs):
        ...

    def __call__(self, *, actual=None, **kwargs) -> bool:
       ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
✨ enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant