-
-
Notifications
You must be signed in to change notification settings - Fork 532
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Schematic diagram for THC #855
Open
evader
wants to merge
7
commits into
bdring:main
Choose a base branch
from
wocpsu:master
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Initial Attempt at adding THC This is the start of adding Torch Height Control to the ESP32 grbl repo. I still have a lot of work to do and I will test before starting a pull request. * Updates to get THC Closer to a testing state Updated the torch height control to be closer to a state when I'm ready to test it. * Adding New THC Settings Added new configurable settings (Arc Delay Time, Voltage Filter TC, and THC Iteration Frequency) * Tested THC on ESP32 Board Working on ESP32 Board. Haven't tested on CNC yet. * Commit After Getting THC Running On Machine First test with all the hardware. The plasma torch height control works when cutting metal but needs some tuning at this point.
* Fixed status polling issue with Huanyang spindle. * Cleaning up the comments on the Huanyang * Re fix reset (bdring#501) * Better fix for ^x reset problem By using an existing function instead of making a new one. The existing function was buggy, so fixed it. * Bump version * Spindle Updates - protocol.cpp when spindle speed is overridden, spindlee object gets notified - protocol.cpp Reformat - HuanyanySpindle.cpp - Prevent it from running if the $Spindle/Type is changed to Haunyang, but the pins were not defined. - Increase command queue size from 5 to 10. Queue is cleared if M5 is received. - Added spindle override to Huanyang. * Fixed compile with PARKING_ENABLE * Fixed laser mode issue in parking The big Settings change lost a ! in the conditional for parking. * Add Visual Studio support * Oops, platformio.ini mod was wrong Co-authored-by: bdring <[email protected]> Co-authored-by: Mitch Bradley <[email protected]>
Working great on my pllasma cutter. I noticed I was using delay ms and not us(microseconds) for the direction and step delays. It works much better now.
general commenting clean-up. Adding boolean to always print THC state when it's running
Adds steps to stepper.cpp
mazWaz
reviewed
Jan 4, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this working for thc?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi. Sorry if this is the wrong way of getting in contact. Do you have the schematic for your THC. I am trying to replicate this setup as I love the GRBL ESP32 project and am now moving into the plasma cutting scene.