Some code cleanups for the repeat mode #1024
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In text UI, when retrying after an error in repeat mode, unnecessary amount of code was being re-executed on each retry. This patch removes the early init code from the retry loop as it only needs to be executed once and will either succeed or fail, there is no retry. (best reviewed with whitespace ignored)
This patch moves execution of some text UI preferences init code, which does not need to be repeated every time, out of the retry loop (that is, from after a successful connection to before attempting the connection). (best reviewed with moves highlighted and indentation ignored; for example: --color-moved --color-moved-ws=allow-indentation-change)
Clean up the exception matching and retry handling code, to unify UI termination and reduce code duplication.
The [exn2str] function used to add superfluous labels to error messages, in some cases classifying errors as fatal or not (historically likely at least partially due to debugging needs). This function does not know the consequences of the error nor further actions to be taken. These labels can then become misleading. These labels, if needed at all, should be under the control of each respective UI.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR extracts the more general commits from #1013.