Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Change enum BTF_HIDEMOREBUTTON from 0x006 to 0x400, otherwise it will conflict with BTF_ATTACHREPORT. #44

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

fix: Change enum BTF_HIDEMOREBUTTON from 0x006 to 0x400, otherwise it will conflict with BTF_ATTACHREPORT. #44

wants to merge 2 commits into from

Conversation

jimmyleocn
Copy link

Fixed enum error, otherwise you couldn't see the "More.." button when you use BTF_ATTACHREPORT flag.

Xottab-DUTY
Xottab-DUTY approved these changes Oct 3, 2024
View reviewed changes
Copy link

@Xottab-DUTY Xottab-DUTY left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agree on the change itself, but it's better to not change the encoding.
If possible, please revert the encoding change.

source/Client/BugTrap.h Outdated Show resolved Hide resolved
source/Client/BugTrap.h Outdated Show resolved Hide resolved
Xottab-DUTY
Xottab-DUTY approved these changes Oct 4, 2024
View reviewed changes
Copy link

@Xottab-DUTY Xottab-DUTY left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jimmyleocn thanks!

Ready to merge by @bchavez, hopefully!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Xottab-DUTY Xottab-DUTY Xottab-DUTY approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jimmyleocn @Xottab-DUTY