Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix:ORV2-3093 - Handle CDOGS 404 and async doc generation at time of issuance. #1673

Merged
merged 2 commits into from
Nov 26, 2024
Merged

fix:ORV2-3093 - Handle CDOGS 404 and async doc generation at time of issuance. #1673

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
1a2ee62
fix: ORV2-3093 - Workaround for CDOGS bug that throws 404 when proces…
praju-aot Nov 26, 2024
ecc2122
fix: Make the permit and receipt pdf generation asynchronous at time …
praju-aot Nov 26, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion dops/src/modules/common/common.service.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,11 @@ export class CommonService {
error.code === 'ECONNABORTED' ||
error.code === 'ECONNREFUSED' ||
error.code === 'ECONNRESET' ||
error.response?.status >= 500
error.response?.status >= 500 ||
//CDOGS has a bug that throws 404 when processing multiple requests at
//a time. It's resolved on retry.
(error.response?.status === 404 &&
error.config.url === process.env.CDOGS_URL)
);
},
onRetry: (retryCount, error, requestConfig) => {
Expand Down
2 changes: 1 addition & 1 deletion ...cles/src/modules/permit-application-payment/application/company-application.controller.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -316,7 +316,7 @@ export class CompanyApplicationController {
);

if (result?.success?.length) {
await Promise.allSettled([
void Promise.allSettled([
this.permitReceiptDocumentService.generatePermitDocuments(
currentUser,
result.success,
Expand Down
Loading