Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Map race conditions #266

Merged
merged 9 commits into from
Oct 17, 2024
Merged

Map race conditions #266

merged 9 commits into from
Oct 17, 2024

Conversation

popkinj
Copy link
Collaborator

@popkinj popkinj commented Oct 17, 2024

  • Map state hardening.
  • Fixed the map freeze issue
  • Fixed the missing mask on draft project/plans

@popkinj popkinj requested review from KjartanE and oscar-ip October 17, 2024 16:18
Copy link

codecov bot commented Oct 17, 2024

Codecov Report

Attention: Patch coverage is 0% with 229 lines in your changes missing coverage. Please review.

Project coverage is 39.36%. Comparing base (e595318) to head (2b046ca).
Report is 1 commits behind head on dev.

Files with missing lines Patch % Lines
app/src/components/map/MapContainer.tsx 0.00% 225 Missing ⚠️
...atures/projects/components/ProjectLocationForm.tsx 0.00% 4 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##              dev     #266      +/-   ##
==========================================
- Coverage   39.44%   39.36%   -0.09%     
==========================================
  Files         320      320              
  Lines       10186    10207      +21     
  Branches     1892     1903      +11     
==========================================
  Hits         4018     4018              
- Misses       5963     5984      +21     
  Partials      205      205              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@oscar-ip oscar-ip left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! :-)

@popkinj popkinj merged commit cf7de56 into dev Oct 17, 2024
18 of 20 checks passed
@popkinj popkinj deleted the NERT-race branch October 17, 2024 17:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants