Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[INV-3793] Generic Base Class for Caching -- Merges into 3805 #3806

Merged

Conversation

LocalNewsTV
Copy link
Collaborator

@LocalNewsTV LocalNewsTV commented Jan 16, 2025

Overview

Caution

This PR is forked off of PR #3805. This Merge is to merge it into that PR!
It was done this way to make differentiating the Two easier

Important

If this Pr is declined but the other is approved, I will simply decouple this PR, make corrections, then open a new one.

Whats Here

  • Create Generic Base class for Caching to bear some level of consistency between the caches. Class implements the shared functions between RecordCache and TileCache classes

    • Generic class takes in 4 Type Parameters for consistency across the sub Functionality
  • Add typing to returns of Cache Factories, to typeguard when we instantiate these classes. Previously they'd show as Any in most cases.

  • Update some function names

  • The only functionality that was changed was the createRepository functionality in TileCache being changed to createOrUpdateRepository It now can update repositories.

image

image

Shiny Type guards

Copy link

Quality Gate Failed Quality Gate failed

Failed conditions
0.0% Coverage on New Code (required ≥ 80%)

See analysis details on SonarQube Cloud

@LocalNewsTV LocalNewsTV changed the title [INV-3793] Generic Base Class for Caching [INV-3793] Generic Base Class for Caching -- Merges into 3805 Jan 16, 2025
@LocalNewsTV LocalNewsTV linked an issue Jan 16, 2025 that may be closed by this pull request
2 tasks
@plasticviking plasticviking merged commit 99cf009 into 3779-use-local-database-over-redux Jan 17, 2025
3 of 7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Create common base class for all caching mechanisms
2 participants