[INV-3793] Generic Base Class for Caching -- Merges into 3805 #3806
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Caution
This PR is forked off of PR #3805. This Merge is to merge it into that PR!
It was done this way to make differentiating the Two easier
Important
If this Pr is declined but the other is approved, I will simply decouple this PR, make corrections, then open a new one.
Whats Here
Create Generic Base class for Caching to bear some level of consistency between the caches. Class implements the shared functions between RecordCache and TileCache classes
Add typing to returns of Cache Factories, to typeguard when we instantiate these classes. Previously they'd show as
Any
in most cases.Update some function names
The
only
functionality that was changed was thecreateRepository
functionality inTileCache
being changed tocreateOrUpdateRepository
It now can update repositories.Shiny Type guards