fix[DETACH EVENT] Fix bug when detaching all events

bcerati · Apr 23, 2020 · 090ccbb · 090ccbb
1 parent 870fb95
commit 090ccbb
Showing 1 changed file with 9 additions and 2 deletions.
diff --git a/src/index.js b/src/index.js
@@ -113,15 +113,22 @@
        * @param {callback} callback - the callback to remove (undefined to remove all of them).
        */
       detach: function(eventName, callback) {
+        if (callback === undefined) {
+          that.listeners[eventName] = [];
+          return true;
+        }
+
         for (var k in that.listeners[eventName]) {
           if (
             that.listeners[eventName].hasOwnProperty(k) &&
-            (that.listeners[eventName][k].callback === callback ||
-              callback === undefined)
+            that.listeners[eventName][k].callback === callback
           ) {
             that.listeners[eventName].splice(k, 1);
+            return this.detach(eventName, callback);
           }
         }
+
+        return true;
       },
 
       /**