Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

upgrade to pytorch 1.1.0a0+ec8b1c9 #30

Open
wants to merge 5 commits into
base: master
Choose a base branch
from
Open

upgrade to pytorch 1.1.0a0+ec8b1c9 #30

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
ee7f435
Update meta.yaml
h3jia Feb 14, 2019
f940d32
Delete gloo-SPEED_UNKNOWN.patch
h3jia Feb 14, 2019
b47ac1e
Update build.sh
h3jia Feb 14, 2019
02e5292
Build libtorch
h3jia Feb 15, 2019
f50f271
Update build.sh
h3jia Feb 15, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 12 additions & 1 deletion platform/pytorch-cpu/build.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,5 +3,16 @@ export NO_CUDA=1
export CMAKE_PREFIX_PATH=$PREFIX

export VERBOSE=1
patch -p1 -d third_party/gloo < ${RECIPE_DIR}/gloo-SPEED_UNKNOWN.patch
$PYTHON setup.py install

{
{
mkdir build_libtorch
cd build_libtorch
BUILD_TORCH=ON ONNX_NAMESPACE=onnx_torch bash ../tools/build_pytorch_libs.sh --use-nnpack caffe2
} && {
echo -e "\nSuccessfully built libtorch at `dirname $PWD`/torch/lib/tmp_install\n"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmm. but why not install libtorch to the proper directory? Is it because there is a conflict?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It seems that in fact it's also built in torch/, and they've removed /torch/lib/tmp_install in a later commit. I just tried the latest version, and pytorch itself was built successfully. But they changed the way to build libtorch, and there's a bug that I don't know how to fix. I'm gonna ask them before updating this PR.

}
} || {
echo -e "\nError: failed to build libtorch\n"
}
37 changes: 0 additions & 37 deletions platform/pytorch-cpu/gloo-SPEED_UNKNOWN.patch
View file
Open in desktop

This file was deleted.

4 changes: 2 additions & 2 deletions platform/pytorch-cpu/meta.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,11 +1,11 @@
package:
name: pytorch-cpu
version: 0.4.0
version: 1.1.0

source:
# use git checkout to recursively get the submodule dependencies
# the release tarballs do not carry dependencies.
git_rev: v0.4.0
git_rev: ec8b1c9
git_url: https://github.com/pytorch/pytorch/

build:
Expand Down