Don't create override font if previousFont is null anyways

bbepis · Oct 27, 2024 · 544d1b3 · 544d1b3
1 parent f9724b6
commit 544d1b3
Showing 1 changed file with 2 additions and 1 deletion.
diff --git a/src/XUnity.AutoTranslator.Plugin.Core/TextTranslationInfo.cs b/src/XUnity.AutoTranslator.Plugin.Core/TextTranslationInfo.cs
@@ -129,8 +129,9 @@ public void ChangeFont( object ui )
             var fontProperty = clrType.CachedProperty( "font" );
 
             var previousFont = fontProperty.Get( ui );
+            if( previousFont == null ) return;
             var newFont = FontCache.GetOrCreateOverrideFontTextMeshPro();
-            if( newFont == null || previousFont == null ) return;
+            if( newFont == null ) return;
 
             if( !UnityObjectReferenceComparer.Default.Equals( newFont, previousFont ) )
             {