Fixed rendering issues with detailed polylines #18
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added the simplify step before offsetting the actual point. This reduces the number of points in the line and smooths it. The end result is unaffected in simple polylines and is significantly improved on detailed polylines.
Using the smoothing values of the options is a nicer solution than the hardcoded default value of 1. The option should always be available because its set by default in leaflet. If its not there, you definitely broke something.
|
Works great on my end, thanks |
|
@bbecquet could you please merge this? Would really like to reuse this fix as a part of PolylineOffset release. |
|
@bbecquet could you please merge this? Would be really great to have this |
thiphariel
added a commit
to Latitude-Cartagene/Leaflet.PolylineOffset
that referenced
this pull request
Jan 15, 2020
|
Sorry I know it's a bit ridiculous to merge this PR sooo late… I haven't maitained this plugin at all for 3 years, and now I hope to find time to rewrite it from scratch, as I think there are fundamental design flaws that cause most of the problems. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added the simplify step before offsetting the actual point. This reduces the number of points in the line and smooths it. The end result is unaffected in simple polylines and is significantly improved on detailed polylines.
This should fix issues as seen in #1