Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

turn on sourcemaps #157

Merged
merged 1 commit into from
May 10, 2019
Merged

turn on sourcemaps #157

merged 1 commit into from
May 10, 2019

Conversation

terite
Copy link
Contributor

@terite terite commented May 10, 2019

Is your Pull Request request related to another issue in this repository ?
No, but it is related to mac-s-g/react-json-view#226.

Describe what the PR does
This PR tells webpack to generate sourcemaps when running component:build, which has two benefits

  1. allows for easier debugging when using the built version of the component.
  2. silences a webpack error. Read more about this in the linked ticket above.

State whether the PR is ready for review or whether it needs extra work
Ready.

Additional context
For more information about the webpack warning, see webpack-contrib/source-map-loader#82

@pietrop pietrop merged commit 575f7fa into bbc:master May 10, 2019
@terite terite deleted the add-sourcemaps branch May 10, 2019 16:48
@terite
Copy link
Contributor Author

terite commented May 10, 2019

Thanks for all your quick reviews!

@pietrop
Copy link
Contributor

pietrop commented May 10, 2019

Thank you for your PRs @terite 🙌

Out of curiosity what is your main use case for this component?

@terite
Copy link
Contributor Author

terite commented May 14, 2019

I'm using this component to help transcribe short medical dictations. It's a nice improvement coming from <textarea>

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants