-
Notifications
You must be signed in to change notification settings - Fork 443
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix toolchain repo aliases and add a test. #3181
Conversation
@UebelAndre a fix and test for the repo aliasing |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! Just one question
@@ -269,7 +269,7 @@ def rust_register_toolchains( | |||
sha256s = sha256s, | |||
urls = urls, | |||
versions = versions, | |||
aliases = aliases, | |||
aliases = dict(aliases), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What exactly is this fixing?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
When I originally implemented this feature, I added a check that when you aliased a repository that repository existed. I did it by removing entries from this dict as they were consumed.
It worked for the check, but it emptied the dict for when we actually make the repos below. Unfortunately I thought bringing the repo into scope with use_repo in the test was sufficient, but actually we needed to use the repo in the build for it to be fetched.
Functional testAlias a junk repo name:
Add tests in tests/aliased_toolchains to actually use an aliased repository. Example failed test before the dict(aliases) call:
|
@UebelAndre questions resolved, should be good to go. |
No description provided.