Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Migrated Android example to bzlmod #3133

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

Migrated Android example to bzlmod #3133

wants to merge 4 commits into from
+185 −71

Conversation

UebelAndre
Copy link
Collaborator

No description provided.

@UebelAndre
Copy link
Collaborator Author

@keith I'm wondering if you can help me get the Android examples building again 😅

@keith
Copy link
Member

keith commented Jan 6, 2025

it looks like the missing piece is this dropped rules_android_ndk in the MODULE.bazel which was previously in the WORKSPACE, that's what should register the toolchain

@UebelAndre UebelAndre marked this pull request as ready for review January 6, 2025 18:31
@UebelAndre UebelAndre enabled auto-merge January 6, 2025 18:31
@UebelAndre
Copy link
Collaborator Author

Thanks @keith!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@keith keith keith approved these changes

@illicitonion illicitonion Awaiting requested review from illicitonion

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@UebelAndre @keith