Error on absolute src paths #2853
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
illicitonion
force-pushed
the
error-on-absoloute-srcs
branch
2 times, most recently
from
84a1dd4 to
2fd9476
Compare
These lead to non-deterministic lockfile contents because they depend on the depth of the directory the repo is checked out into. This may possibly introduce false positives because of hard-coded /dev/null or similar in actual published crates - hopefully it doesn't (ideally people aren't publishing this kind of thing to crates.io), but if it does, we can loosen those to a warning or add a per-crate opt-out or something.
illicitonion
force-pushed
the
error-on-absoloute-srcs
branch
from
2fd9476 to
93eea81
Compare
UebelAndre
approved these changes
Sep 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These lead to non-deterministic lockfile contents because they depend on the depth of the directory the repo is checked out into.
This may possibly introduce false positives because of hard-coded /dev/null or similar in actual published crates - hopefully it doesn't (ideally people aren't publishing this kind of thing to crates.io), but if it does, we can loosen those to a warning or add a per-crate opt-out or something.