Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add recurse option to pkg_zip to maintain directory structure #428

Closed
wants to merge 2 commits into from

Conversation

hborawski
Copy link

Need to maintain the zip directory structure for zipping cocoapods as a part of the build, otherwise the glob wont match from the podspec file (or i'd end up matching test files from a test_spec as well as source files)

...
s.source_files = "SomePod/Sources/**/*.swift"
s.test_spec do |tests|
  tests.source_files = "SomePod/Tests/**/*.swift"
end

pkg_zip with glob(["SomePod/Sources/**/*.swift"]) will produce a zip with all swift files in a flat directory

I can solve this simple example with package_dir = 'SomePod/Sources' but looking for a longer term solution because i want to use this on pods with multiple subspecs

@hborawski hborawski requested review from aiuto and nacl as code owners October 4, 2021 21:59
@aiuto
Copy link
Collaborator

aiuto commented Oct 5, 2021

Can you create an issue that describes the broader problem?
My inclination is to not even review this. The main reason is that it is a special hack to pkg_zip, and not reusable across all the other package types. This should be implemented as extensions to pkg_files, if anywhere.

Copy link
Collaborator

@aiuto aiuto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Needs discussion first.

@hborawski
Copy link
Author

issue created: #434

@hborawski
Copy link
Author

Closing due to resolution in #434

@hborawski hborawski closed this Nov 10, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants