Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not fail in case of empty image label values #2276

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

hisener
Copy link

@hisener hisener commented Sep 28, 2023

If I understand correctly, image label value may be an empty string. However, in that case, I got "index out of range" errors in two places. This PR uses startswith to avoid them.

	File "/private/var/tmp/_bazel_halil.sener/f6fb7d40b6b3160ce57e2d52769a8d36/external/io_bazel_rules_docker/container/image.bzl", line 976, column 76, in container_image
		files = sorted({v[1:]: None for v in kwargs["labels"].values() if v[0] == "@"}.keys())
Error: index out of range (index is 0, but sequence has 0 elements)
	File "/private/var/tmp/_bazel_halil.sener/f6fb7d40b6b3160ce57e2d52769a8d36/external/io_bazel_rules_docker/container/image.bzl", line 199, column 17, in _image_config
		if fname[0] == "@":
Error: index out of range (index is 0, but sequence has 0 elements)

PR Checklist

Please check if your PR fulfills the following requirements:

  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Documentation content changes
  • Other... Please describe:

What is the current behavior?

Issue Number: N/A

What is the new behavior?

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

Copy link

This Pull Request has been automatically marked as stale because it has not had any activity for 180 days. It will be closed if no further activity occurs in 30 days.
Collaborators can add an assignee to keep this open indefinitely. Thanks for your contributions to rules_docker!

@github-actions github-actions bot added the Can Close? Will close in 30 days unless there is a comment indicating why not label Dec 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Can Close? Will close in 30 days unless there is a comment indicating why not
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant