docker_push: allow passing cred_helpers from toolchain into commands #2257
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
manuelnaranjo
requested review from
gravypod,
linzhp,
pcj,
smukherj1 and
uhthomas
as code owners
When an environment sets up the credentials helpers and configuration it's expected the behaviour that container_pull provides is also offered by container_push
manuelnaranjo
force-pushed
the
mnaranjo/container-push
branch
from
590ffa8 to
261fab7
Compare
|
@uhthomas maybe you can review? CI is not passing because of ubuntu 22.04 issues |
|
This Pull Request has been automatically marked as stale because it has not had any activity for 180 days. It will be closed if no further activity occurs in 30 days. |
github-actions
bot
added
the
Can Close?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When an environment sets up the credentials helpers and configuration it's expected the behaviour that container_pull provides is also offered by container_push
PR Checklist
Please check if your PR fulfills the following requirements:
There are no tests for container_push, didn't explore adding those, in terms of docs the documented behaviour is not what's happening, after this PR docs and behaviour matches.
PR Type
What kind of change does this PR introduce?
What is the current behavior?
Workspace configures toolchain with both client_config and cred_helpers but yet the container_push is not authenticated, unless the helpers are in the host $PATH, leading to non reproducible setups.
Issue Number: 2126
What is the new behavior?
Workspace configures toolchain with both client_config and cred_helpers but now the provided cred_helpers are used for authentication not relying on host setup.
Does this PR introduce a breaking change?
Other information
Using it internally at booking.com already