Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Document empty_files #1560

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

Document empty_files #1560

wants to merge 4 commits into from

Conversation

zoidyzoidzoid
Copy link
Contributor

No description provided.

@zoidyzoidzoid
Copy link
Contributor Author

/assign @alex1545

alex1545
alex1545 reviewed Jul 29, 2020
View reviewed changes
Copy link
Contributor

@alex1545 alex1545 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for this PR improving our docs.
Please address the comments I left so we can merge this.

README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
@k8s-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: zoidbergwill
To complete the pull request process, please assign after the PR has been reviewed.
You can assign the PR to them by writing /assign in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

zoidyzoidzoid
zoidyzoidzoid commented Mar 11, 2021
View reviewed changes
README.md Outdated Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alex1545 alex1545 alex1545 left review comments

@smukherj1 smukherj1 Awaiting requested review from smukherj1 smukherj1 is a code owner

@hicksjoseph hicksjoseph Awaiting requested review from hicksjoseph

At least 1 approving review is required to merge this pull request.

Assignees

@alex1545 alex1545

Labels
cla: yes size/S
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@zoidyzoidzoid @k8s-ci-robot @alex1545 @googlebot