Move apple specific linking logic from bazel #2609
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
keith
requested review from
aaronsky,
BalestraPatrick,
brentleyjones,
luispadron,
mattrobmattrob and
thii
as code owners
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
luispadron
approved these changes
Dec 5, 2024
|
depends on #2611 |
keith
force-pushed
the
ks/move-apple-specific-linking-logic-from-bazel
branch
3 times, most recently
from
2259900 to
a224a97
Compare
keith
force-pushed
the
ks/move-apple-specific-linking-logic-from-bazel
branch
from
a6ef7ec to
7ed23bb
Compare
since we use bazel's internal linking function on 7.x, it looks for this old provider, so we can't use the new one until we drop that.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cherry picks:
Fixes #2604