Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add missing rules_apple allowlist alias #24582

Closed
wants to merge 1 commit into from
Closed

Add missing rules_apple allowlist alias #24582

wants to merge 1 commit into from

Conversation

keith
Copy link
Member

@keith keith commented Dec 5, 2024

If this is used from a WORKSPACE, or used in bzlmod with the repo name
overridden to the old name, rules_apple isn't correct for this
allowlist.

@keith
Add missing rules_apple allowlist alias
6bf9611 
If this is used from a WORKSPACE, or used in bzlmod with the repo name
overridden to the old name, rules_apple isn't correct for this
allowlist.
@keith keith mentioned this pull request Dec 5, 2024
Merged
@github-actions github-actions bot added the awaiting-review PR is awaiting review from an assigned reviewer label Dec 5, 2024
@keith keith mentioned this pull request Dec 5, 2024
Closed
@keith keith requested a review from pzembrod December 5, 2024 22:48
@keith
Copy link
Member Author

keith commented Dec 5, 2024

@bazel-io flag

@bazel-io bazel-io added the potential release blocker Flagged by community members using "@bazel-io flag". Should be added to a release blocker milestone label Dec 5, 2024
@keith keith mentioned this pull request Dec 5, 2024
Merged
keith added a commit to bazelbuild/rules_apple that referenced this pull request Dec 6, 2024
@keith
Remove internal uses of @build_bazel_rules_apple (#2614)
f0d6d59 
This is just nice to do, but also works around
bazelbuild/bazel#24582 for now
@fmeum
Copy link
Collaborator

fmeum commented Dec 6, 2024

@pzembrod

@meteorcloudy
Copy link
Member

It's a bit unfortunately we discovered this so late, do we need a new rc for Bazel 8 or this issue can still be worked around from rules_apple by bazelbuild/rules_apple#2614?

@pzembrod pzembrod added awaiting-PR-merge PR has been approved by a reviewer and is ready to be merge internally and removed awaiting-PR-merge PR has been approved by a reviewer and is ready to be merge internally labels Dec 6, 2024
@pzembrod
Copy link
Contributor

pzembrod commented Dec 6, 2024

@keith Thanks for the fix.

@meteorcloudy @keith I would think that for the change in AppleBootstrap.java we don't need a new RC; since the flag INCOMPATIBLE_STOP_EXPORTING_LANGUAGE_MODULES is still false by default, I would expect bazel 8 to work even with an incomplete allow list.

I don't know about the change in BuiltinRestriction.java, however. @keith Does the missing entry actually break something with bazel 8 atm?

@pzembrod pzembrod added awaiting-PR-merge PR has been approved by a reviewer and is ready to be merge internally and removed awaiting-review PR is awaiting review from an assigned reviewer labels Dec 6, 2024
@brentleyjones
Copy link
Contributor

Workspace users will be broken without this fix because of BuiltinRestriction.java. This needs to go into 8.0.

@meteorcloudy
Copy link
Member

@bazel-io fork 8.0.0

@bazel-io bazel-io removed the potential release blocker Flagged by community members using "@bazel-io flag". Should be added to a release blocker milestone label Dec 6, 2024
@bazel-io bazel-io mentioned this pull request Dec 6, 2024
Closed
@meteorcloudy
Copy link
Member

@brentleyjones Can you make a new release of the apple rules? Maybe we could also fix #24583

@meteorcloudy meteorcloudy mentioned this pull request Dec 6, 2024
Open
@brentleyjones
Copy link
Contributor

bazelbuild/bazel-central-registry@73e7150

@copybara-service copybara-service bot closed this in 2e58ac0 Dec 6, 2024
@github-actions github-actions bot removed the awaiting-PR-merge PR has been approved by a reviewer and is ready to be merge internally label Dec 6, 2024
meteorcloudy pushed a commit to meteorcloudy/bazel that referenced this pull request Dec 6, 2024
@keith @meteorcloudy
[8.0.0] Add missing rules_apple allowlist alias
d0da8fe 
If this is used from a WORKSPACE, or used in bzlmod with the repo name
overridden to the old name, rules_apple isn't correct for this
allowlist.

Closes bazelbuild#24582.

PiperOrigin-RevId: 703493907
Change-Id: Ie4f88de60775c50874169e4fb5712b7b5fe8b8bd
@meteorcloudy meteorcloudy mentioned this pull request Dec 6, 2024
Merged
meteorcloudy pushed a commit to meteorcloudy/bazel that referenced this pull request Dec 6, 2024
@keith @meteorcloudy
Add missing rules_apple allowlist alias
6bdc8cf 
If this is used from a WORKSPACE, or used in bzlmod with the repo name
overridden to the old name, rules_apple isn't correct for this
allowlist.

Closes bazelbuild#24582.

PiperOrigin-RevId: 703493907
Change-Id: Ie4f88de60775c50874169e4fb5712b7b5fe8b8bd
@keith keith deleted the ks/add-missing-rules_apple-allowlist-alias branch December 6, 2024 17:24
@keith
Copy link
Member Author

keith commented Dec 6, 2024

i don't think that release will fix anything, but i hope to finish bazelbuild/rules_apple#2609 today, which should

@iancha1992
Copy link
Member

The changes in this PR have been included in Bazel 8.0.0 RC8. Please test out the release candidate and report any issues as soon as possible.
If you're using Bazelisk, you can point to the latest RC by setting USE_BAZEL_VERSION=8.0.0rc8. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pzembrod pzembrod pzembrod approved these changes

@brentleyjones brentleyjones brentleyjones approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@keith @fmeum @meteorcloudy @pzembrod @brentleyjones @iancha1992 @bazel-io