Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor where IsDirectory is stored in the file metadata #231

Merged
merged 1 commit into from
Nov 6, 2020
Merged

Refactor where IsDirectory is stored in the file metadata #231

merged 1 commit into from
Nov 6, 2020

Conversation

k-ye
Copy link
Contributor

@k-ye k-ye commented Nov 6, 2020 •
edited
Loading

This is a prep step to address #229 (comment). I find the code to handle symlinks a bit too complicated when IsDirectory is put inside the FileError, especially when symlink and directory are both true.

@google-cla google-cla bot added the cla: yes The author signed a CLA label Nov 6, 2020
atetubou
atetubou approved these changes Nov 6, 2020
View reviewed changes
Copy link
Collaborator

@atetubou atetubou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me

@k-ye k-ye requested a review from gkousik November 6, 2020 12:44
@gkousik gkousik merged commit 5e12d9e into bazelbuild:master Nov 6, 2020
@k-ye k-ye deleted the is-dir branch November 7, 2020 03:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gkousik gkousik gkousik approved these changes

@atetubou atetubou atetubou approved these changes

@ola-rozenfeld ola-rozenfeld Awaiting requested review from ola-rozenfeld

Assignees
No one assigned
Labels
cla: yes The author signed a CLA
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@k-ye @atetubou @gkousik