Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow native.bazel_version to be overridden for dev builds #24669

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

fmeum
Copy link
Collaborator

@fmeum fmeum commented Dec 12, 2024

This is necessary to allow for accurate bisects of Bazel issues when rules rely on bazel_features for feature detection. The variable can be used to force the lowest version relevant to the bisect or, in the future, bazelisk --bisect could extrapolate the release version from tags.

@fmeum fmeum requested a review from a team as a code owner December 12, 2024 17:44
@fmeum fmeum requested review from gregestren and meteorcloudy and removed request for a team and gregestren December 12, 2024 17:44
@github-actions github-actions bot added team-Configurability platforms, toolchains, cquery, select(), config transitions awaiting-review PR is awaiting review from an assigned reviewer labels Dec 12, 2024
@fmeum fmeum force-pushed the 24619-override-bazel-version branch from 6af8321 to 1dd6ed9 Compare December 13, 2024 07:37
This is necessary to allow for accurate bisects of Bazel issues when rules rely on `bazel_features` for feature detection. The variable can be used to force the lowest version relevant to the bisect or, in the future, `bazelisk --bisect` could extrapolate the release version from tags.
@fmeum fmeum force-pushed the 24619-override-bazel-version branch from 1dd6ed9 to b0d7f48 Compare December 13, 2024 11:37
@meteorcloudy meteorcloudy added awaiting-PR-merge PR has been approved by a reviewer and is ready to be merge internally and removed awaiting-review PR is awaiting review from an assigned reviewer labels Dec 13, 2024
@fmeum
Copy link
Collaborator Author

fmeum commented Dec 13, 2024

@bazel-io fork 8.0.1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
awaiting-PR-merge PR has been approved by a reviewer and is ready to be merge internally team-Configurability platforms, toolchains, cquery, select(), config transitions
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants