Fix checking TEST_PREMATURE_EXIT_FILE #24657
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
meteorcloudy
requested review from
fmeum and
lberki
and removed request for
fmeum
github-actions
bot
added
the
awaiting-review
fmeum
reviewed
Dec 12, 2024
| if (actionExecutionContext | ||
| .getPathResolver() | ||
| .convertPath(resolvedPaths.getExitSafeFile()) | ||
| .delete() && testResultDataBuilder.getTestPassed()) { |
There was a problem hiding this comment.
I see three different changes in this PR:
- This block has been moved further down.
- The block only triggers if the test would otherwise pass.
- The file is deleted.
While all three make sense, which one (or which subset) is required to fix the bug? I would have guessed that only 2. should be necessary.
There was a problem hiding this comment.
I think the change actually fixed the issue is actually "deleting the TEST_PREMATURE_EXIT_FILE when the test times out"
Initially, I thought it could be fixed by just changing exists to delete, but it didn't work.
fmeum
approved these changes
Dec 12, 2024
github-actions
bot
removed
the
awaiting-review
bazel-io
pushed a commit
to bazel-io/bazel
that referenced
this pull request
Dec 12, 2024
`TEST_PREMATURE_EXIT_FILE` was not cleaned up between test attempts (--flaky_test_attempts). Fixes bazelbuild#24655 Closes bazelbuild#24657. PiperOrigin-RevId: 705495967 Change-Id: Ic4d4be1e72230c3a6bc45c9f372d1188fefad201
github-merge-queue bot
pushed a commit
that referenced
this pull request
Dec 12, 2024
`TEST_PREMATURE_EXIT_FILE` was not cleaned up between test attempts (--flaky_test_attempts). Fixes #24655 Closes #24657. PiperOrigin-RevId: 705495967 Change-Id: Ic4d4be1e72230c3a6bc45c9f372d1188fefad201 Commit b33d51f Co-authored-by: Yun Peng <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TEST_PREMATURE_EXIT_FILEwas not cleaned up between test attempts.Fixes #24655