Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Let Turbine handle Unicode paths #24565

Closed
wants to merge 8 commits into from

Conversation

fmeum
Copy link
Collaborator

@fmeum fmeum commented Dec 4, 2024

This requires patching rules_graalvm with sgammon/rules_graalvm#514 to ensure the native image runs with sun.jnu.encoding set to UTF-8 on Linux.

Also enable unrelated tests after the recent java_tools update.

Work towards #24444
Unblocks #24457

@fmeum fmeum force-pushed the 24444-unicode-turbine branch 3 times, most recently from ab449bf to 8bc7632 Compare December 4, 2024 18:34
@fmeum fmeum force-pushed the 24444-unicode-turbine branch 2 times, most recently from 25ca5be to e854a52 Compare December 4, 2024 21:07
@fmeum fmeum force-pushed the 24444-unicode-turbine branch from 374b2ca to 549747d Compare December 5, 2024 09:50
@fmeum fmeum force-pushed the 24444-unicode-turbine branch from 549747d to f95cd43 Compare December 5, 2024 09:51
@fmeum fmeum marked this pull request as ready for review December 5, 2024 09:52
@fmeum fmeum requested a review from a team as a code owner December 5, 2024 09:52
@fmeum fmeum requested a review from cushon December 5, 2024 09:52
@github-actions github-actions bot added team-Rules-Java Issues for Java rules awaiting-review PR is awaiting review from an assigned reviewer labels Dec 5, 2024
@cushon cushon added the awaiting-PR-merge PR has been approved by a reviewer and is ready to be merge internally label Dec 5, 2024
@copybara-service copybara-service bot closed this in a37d288 Dec 6, 2024
@github-actions github-actions bot removed awaiting-PR-merge PR has been approved by a reviewer and is ready to be merge internally awaiting-review PR is awaiting review from an assigned reviewer labels Dec 6, 2024
@fmeum fmeum deleted the 24444-unicode-turbine branch December 6, 2024 11:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
team-Rules-Java Issues for Java rules
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants