[Rolling release] Do not forward legacy cmd.exe variables to the server
#24500
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
team-Rules-CPP
Wyverald
approved these changes
Nov 26, 2024
|
Looks like there was a bad merge somewhere. Could you go to this file |
keertk
merged commit 4754de2
into
bazelbuild:release-9.0.0-pre.20241119.2rc1
45 checks passed
github-actions
bot
removed
the
awaiting-review
keertk
pushed a commit
that referenced
this pull request
Nov 27, 2024
Baseline: ebeab8c Cherry picks: + 650142f: Automated rollback of commit 4515bb6. + 4754de2: [Rolling release] Do not forward legacy `cmd.exe` variables to the server (#24500) + 94fb35b: Fix rolling release (#24513) Incompatible changes: - Changing --test_env no longer invalidates the analysis cache. `ctx.configuration.test_env` may be empty for non-test rules and should not be used by such rules. Important changes: - Add a set data type to Starlark, guarded by the --experimental_enable_starlark_set flag. - symbolic macro attribute inheritance is now marked experimental; set --experimental_enable_macro_inherit_attrs flag to enable it. - Changing any part of `--run_under` that isn't the label (such as the shell command) no longer invalidates the analysis cache. - The progress of completed configured aspects is now shown in the UI, next to the number of completed targets. Example: "(100 packages loaded, 10000 targets and 500 aspects configured)". This release contains contributions from many people at Google, as well as Fabian Meumertzheim, kalvdans, Xùdōng Yáng.
copybara-service bot
pushed a commit
that referenced
this pull request
Nov 27, 2024
Baseline: ebeab8c Cherry picks: + 650142f: Automated rollback of commit 4515bb6. + 4754de2: [Rolling release] Do not forward legacy `cmd.exe` variables to the server (#24500) + 94fb35b: Fix rolling release (#24513) Incompatible changes: - Changing --test_env no longer invalidates the analysis cache. `ctx.configuration.test_env` may be empty for non-test rules and should not be used by such rules. Important changes: - Add a set data type to Starlark, guarded by the --experimental_enable_starlark_set flag. - symbolic macro attribute inheritance is now marked experimental; set --experimental_enable_macro_inherit_attrs flag to enable it. - Changing any part of `--run_under` that isn't the label (such as the shell command) no longer invalidates the analysis cache. - The progress of completed configured aspects is now shown in the UI, next to the number of completed targets. Example: "(100 packages loaded, 10000 targets and 500 aspects configured)". This release contains contributions from many people at Google, as well as Fabian Meumertzheim, kalvdans, Xùdōng Yáng.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes startup failures such as:
Fixes #24448
Closes #24451.
PiperOrigin-RevId: 699115724
Change-Id: Id7a2445e82b24384e9ade0c92ddb343f00e9ab2b