[8.0.0] Do not forward legacy cmd.exe variables to the server
#24456
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This fixes startup failures such as: ``` ERROR: While parsing option --client_env==C:=C:\Users\wyv: Variable definitions must be in the form of a 'name=value' assignment ``` Fixes bazelbuild#24448 Closes bazelbuild#24451. PiperOrigin-RevId: 699115724 Change-Id: Id7a2445e82b24384e9ade0c92ddb343f00e9ab2b
bazel-io
added
area-Windows
meteorcloudy
approved these changes
Nov 22, 2024
Merged
via the queue into
bazelbuild:release-8.0.0
with commit Nov 22, 2024
43cb62a
46 checks passed
github-actions
bot
removed
the
awaiting-review
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes startup failures such as:
Fixes #24448
Closes #24451.
PiperOrigin-RevId: 699115724
Change-Id: Id7a2445e82b24384e9ade0c92ddb343f00e9ab2b
Commit 59eb519