[8.0.0] Re-enable symbolic macro attribute inheritance and remove --experimental_enable_macro_inherit_attrs flag #24445
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…xperimental_enable_macro_inherit_attrs flag After bazelbuild@a2f1f58, macro inheritance API is in a good shape - and without macro inheritance, we wouldn't have any good way for symbolic macros in Bazel 8 to use `testonly`. Considering for how little time the --experimental_enable_macro_inherit_attrs existed, and that no references to it was marked experimental, it seems safe to remove it directly without graveyarding. Cherry-pick of bazelbuild@a39d181 RELNOTES: Re-enable symbolic macro attribute inheritance. PiperOrigin-RevId: 698884636 Change-Id: I7f682949e96b6739e12d8f569a87ef2daf0ea41c
github-actions
bot
added
team-Configurability
Wyverald
approved these changes
Nov 21, 2024
tetromino
added
team-Loading-API
Merged
via the queue into
bazelbuild:release-8.0.0
with commit Nov 21, 2024
16b6096
46 checks passed
github-actions
bot
removed
the
awaiting-review
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After a2f1f58, macro inheritance API is in a good shape - and without macro inheritance, we wouldn't have any good way for symbolic macros in Bazel 8 to use
testonly.Considering for how little time the --experimental_enable_macro_inherit_attrs existed, and that no references to it was marked experimental, it seems safe to remove it directly without graveyarding.
Cherry-pick of
a39d181
RELNOTES: Re-enable symbolic macro attribute inheritance.
PiperOrigin-RevId: 698884636
Change-Id: I7f682949e96b6739e12d8f569a87ef2daf0ea41c