Fix Unicode encoding issues in Bazel's use of Starlark #24417
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fmeum
force-pushed
the
23859-unicode-starlark
branch
3 times, most recently
from
c62a5eb to
0435c09
Compare
fmeum
requested review from
tjgq
and removed request for
tetromino and
brandjon
github-actions
bot
added
the
awaiting-review
iancha1992
added
the
team-Starlark-Integration
|
To be clear, are all string values that Bazel currently passes to split encoded consistently as raw-UTF-bytes? Or is there a possibility that we have a mixture of encodings? |
fmeum
force-pushed
the
23859-unicode-starlark
branch
from
0435c09 to
3728e16
Compare
fmeum
force-pushed
the
23859-unicode-starlark
branch
from
3728e16 to
5de090d
Compare
All strings fed into and obtained from Starlark, in fact every string retained by Bazel, should now be raw UTF-8 bytes. Strings with other encodings are only produced or consumed at I/O boundaries such as in |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bazel internally uses
Stringas a container for raw bytes assumed to be UTF-8, which differs from ordinary usage ofStringas a container for UTF-16 characters. This requires special implementations of certain Starlark functions that care about the notion of a "character":{l,r,}stripmust not strip non-ASCII whitespace as it may be part of a UTF-8-encoded non-whitespace character.json.decodehas to emit UTF-8 bytes rather than UTF-16 characters.Compatibility is verified by running all script-based tests both parsed as UTF-8 and using Bazel's internal encoding.