Preserve analysis cache through --test_env changes
#24398
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fmeum
requested review from
aranguyen and
katre
and removed request for
a team and
aranguyen
github-actions
bot
added
team-Configurability
|
@katre Friendly ping |
|
Thanks for the reminder. I cleaned up the breakages internally, I'm going to import this and test it. I'll report back. |
katre
approved these changes
Dec 4, 2024
|
Okay, argh, it turns out that I did bot clean up the internal breakages: while Bazel enables I'm working with the owners of the one blocking target to clean it up. Sorry for even further delay. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #7450
RELNOTES[INC]: Changing
--test_envno longer invalidates the analysis cache.ctx.configuration.test_envmay be empty for non-test rules and should not be used by such rules.