[8.0.0] Do not export rlocation from test setup
#24281
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The `rlocation` implementation lacks many of the features of the shell runfiles library, which should be dependend on explicitly instead. When called, `rlocation` will now fail with an error message. Closes bazelbuild#24256. PiperOrigin-RevId: 695241586 Change-Id: I7059c329fd6ca518623d7be8ad3514082097c191
bazel-io
added
the
awaiting-review
Wyverald
approved these changes
Nov 11, 2024
Merged
via the queue into
bazelbuild:release-8.0.0
with commit Nov 12, 2024
468858a
46 checks passed
github-actions
bot
removed
the
awaiting-review
iancha1992
added
the
team-OSS
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
rlocationimplementation lacks many of the features of the shell runfiles library, which should be dependend on explicitly instead.When called,
rlocationwill now fail with an error message.Closes #24256.
PiperOrigin-RevId: 695241586
Change-Id: I7059c329fd6ca518623d7be8ad3514082097c191
Commit 1312007