[8.0.0] Use non-snapshotted paths when creating a runfiles symlink tree. #24267
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It has been a long-standing feature of runfiles symlink trees that they reflect changes made to files referenced in them after the tree has been built. In certain scenarios (currently only at Google), the FileSystem implementation may rewrite symlink target paths to point to read-only snapshots, which breaks this feature when using in-process symlink creation. With this change, the rewriting is bypassed in this case. Also improve the documentation for the BlazeModule getFileSystem() and getFileSystemForBuildArtifacts() methods. PiperOrigin-RevId: 690541050 Change-Id: I140cc68ca1b9236e9fb4049830cc3b5629eaf770
github-actions
bot
added
the
awaiting-review
meteorcloudy
approved these changes
Nov 11, 2024
Merged
via the queue into
bazelbuild:release-8.0.0
with commit Nov 11, 2024
2a5c0b7
46 checks passed
github-actions
bot
removed
the
awaiting-review
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It has been a long-standing feature of runfiles symlink trees that they reflect changes made to files referenced in them after the tree has been built. In certain scenarios (currently only at Google), the FileSystem implementation may rewrite symlink target paths to point to read-only snapshots, which breaks this feature when using in-process symlink creation. With this change, the rewriting is bypassed in this case.
Also improve the documentation for the BlazeModule getFileSystem() and getFileSystemForBuildArtifacts() methods.
PiperOrigin-RevId: 690541050
Change-Id: I140cc68ca1b9236e9fb4049830cc3b5629eaf770