[8.0.0] Handle unresolved symlinks correctly when replacing an existing entry in a runfiles tree. #24258
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
awaiting-review
iancha1992
approved these changes
Nov 8, 2024
iancha1992
added
the
team-Local-Exec
…ng entry in a runfiles tree. This edge case was missing from bazelbuild@51d7a3c. Also add minimal unit test coverage for in-process symlink creation. PiperOrigin-RevId: 694504600 Change-Id: Ida73afa1ce5730e885bc970eafd07211d1816e93
tjgq
force-pushed
the
runfiles-symlinks-cherrypick
branch
from
d6fd79e to
8678e4d
Compare
Merged
via the queue into
bazelbuild:release-8.0.0
with commit Nov 12, 2024
faab29c
45 checks passed
github-actions
bot
removed
the
awaiting-review
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This edge case was missing from 51d7a3c.
Also add minimal unit test coverage for in-process symlink creation.
PiperOrigin-RevId: 694504600
Change-Id: Ida73afa1ce5730e885bc970eafd07211d1816e93