Expose android.car jar from android sdk #20712
Conversation
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
github-actions
bot
added
team-Android
nikolai-manzhos
force-pushed
the
expose-android-car-jar
branch
from
e15bcf3 to
f68c332
Compare
There was a problem hiding this comment.
consider also making this change to the starlark version of the rules here:
https://github.com/bazelbuild/rules_android/blob/main/rules/android_sdk_repository/helper.bzl
| native.alias( | ||
| name = "android_car", | ||
| actual = ":android_car-%d" % default_api_level, | ||
| ) |
There was a problem hiding this comment.
this should probably go inside the if above so that the all and ... target patterns still work when the api level is < 29
There was a problem hiding this comment.
Good point, I'll move it. Perhaps we should also consider doing the same thing for org_apache_http_legacy.
There was a problem hiding this comment.
Ended up adding additional check for default_api_level. Moving this to the if statement above could potentially result in creating alias multiple times.
There was a problem hiding this comment.
@ahumesky could you take a look again?
nikolai-manzhos
force-pushed
the
expose-android-car-jar
branch
from
f68c332 to
2853962
Compare
Enable access to android.car library bundled with android sdk
See bazelbuild/rules_android#299