Skip to content

Commit

Permalink
Clear the credentials cache whenever `--credential_helper_cache_durat…
Browse files Browse the repository at this point in the history
…ion` changes.

This provides a convenient way to clear the cache without running a clean command. While we could update the expiration on existing entries, Caffeine doesn't make it easy and it's unclear that the added complexity is worth the benefit (most users will pick an appropriate value once and stick with it).

Also upgrade Caffeine so that tests can use a recently added API.

Fixes #24437.

PiperOrigin-RevId: 705426812
Change-Id: I4b6d055bd0cda847a5bfd678f38aac705e2692b1
  • Loading branch information
tjgq authored and copybara-github committed Dec 12, 2024
1 parent cdab9f5 commit 82c1ff7
Show file tree
Hide file tree
Showing 6 changed files with 288 additions and 249 deletions.
2 changes: 1 addition & 1 deletion MODULE.bazel
Original file line number Diff line number Diff line change
Expand Up @@ -94,7 +94,7 @@ maven.install(
artifacts = [
# keep sorted
"com.beust:jcommander:1.82",
"com.github.ben-manes.caffeine:caffeine:3.0.5",
"com.github.ben-manes.caffeine:caffeine:3.1.8",
"com.github.stephenc.jcip:jcip-annotations:1.0-1",
"com.google.api-client:google-api-client:1.35.2",
"com.google.api-client:google-api-client-gson:1.35.2",
Expand Down
Loading

0 comments on commit 82c1ff7

Please sign in to comment.