Skip to content

Commit

Permalink
Add start/end timestamps to ActionExecuted event protobuf.
Browse files Browse the repository at this point in the history
Also adds a repeated `Any` field for strategies to report strategy-specific
execution details.

First commit addressing issue #19471.

PiperOrigin-RevId: 573896902
Change-Id: I3d58cdfb503d552999c6261fc7fbd04c7d1de835
  • Loading branch information
michaeledgar authored and copybara-github committed Oct 16, 2023
1 parent 14e3d1b commit 2ddacab
Show file tree
Hide file tree
Showing 2 changed files with 12 additions and 1 deletion.
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
load("@rules_java//java:defs.bzl", "java_proto_library")
load("//tools/build_rules:utilities.bzl", "java_library_srcs")
load("@rules_proto//proto:defs.bzl", "proto_library")
load("//tools/build_rules:utilities.bzl", "java_library_srcs")

package(default_visibility = ["//src:__subpackages__"])

Expand Down Expand Up @@ -31,6 +31,7 @@ proto_library(
"//src/main/protobuf:command_line_proto",
"//src/main/protobuf:failure_details_proto",
"//src/main/protobuf:invocation_policy_proto",
"@com_google_protobuf//:any_proto",
"@com_google_protobuf//:duration_proto",
"@com_google_protobuf//:timestamp_proto",
],
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -18,6 +18,7 @@ syntax = "proto3";

package build_event_stream;

import "google/protobuf/any.proto";
import "google/protobuf/duration.proto";
import "google/protobuf/timestamp.proto";
import "src/main/java/com/google/devtools/build/lib/packages/metrics/package_load_metrics.proto";
Expand Down Expand Up @@ -577,6 +578,15 @@ message ActionExecuted {

// Only populated if success = false, and sometimes not even then.
failure_details.FailureDetail failure_detail = 11;

// Start of action execution, before any attempted execution begins.
google.protobuf.Timestamp start_time = 12;

// End of action execution, after all attempted execution completes.
google.protobuf.Timestamp end_time = 13;

// Additional details about action execution supplied by any/all strategies.
repeated google.protobuf.Any strategy_details = 14;
}

// Collection of all output files belonging to that output group.
Expand Down

0 comments on commit 2ddacab

Please sign in to comment.