-
Notifications
You must be signed in to change notification settings - Fork 366
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add rules_graalvm
module
#836
Conversation
@fmeum looks like it needs a repository alias:
I've only applied the Thank you for approving. |
Yes, you can make any changes to this PR you want, modules are only immutable after merge. I looked into https://github.com/sgammon/rules_graalvm/blob/main/graalvm/BUILD.bazel and would recommend moving the stardoc targets to a dedicated |
- fix: move doc targets, recommended in bazelbuild/bazel-central-registry#836 - chore: update module lock - chore: public visibility for `bzl_library` targets (downstream docs) (thank you @fmeum!)
- fix: move doc targets, recommended in bazelbuild/bazel-central-registry#836 - chore: update module lock - chore: public visibility for `bzl_library` targets (downstream docs) (thank you @fmeum!)
@fmeum I've fixed the doc targets, but I'm guessing I should issue a new release and return to this PR with a force push on I suppose I could avoid re-tagging and only upload a new stable release tarball, with fixed doc targets. That feels like cheating but I suppose it would work, right? |
You could either close this PR and open a new one or force push over it - modules are only immutable after having been merged.
While this would work, it's of course more transparent if there is a tag corresponding to that tar ball. |
32b1e4b
to
a608e67
Compare
rules_graalvm
modulerules_graalvm
module (WIP)
80261a8
to
63a640c
Compare
- supersedes bazel/bazel-central-registry#865 - supersedes bazel/bazel-central-registry#869 - supersedes bazel/bazel-central-registry#911 - supersedes bazel/bazel-central-registry#912 Signed-off-by: Sam Gammon <[email protected]>
63a640c
to
68806c0
Compare
rules_graalvm
module (WIP)rules_graalvm
module
@fmeum this should finally be ready to go 😄 |
Ahhh, it looks like the other one was merged instead, auto-sent by the PR bot (#912). That's bad because the integrity value has been updated since that PR -- I was unable to prevent that PR since it was filed by the GitHub App (I had disabled my workflow thinking that was it, but it crept through anyway). I will publish a fix release immediately, because I figure BCR modules can't be edited after merge @fmeum. Very sorry about this mess of all these PRs. After this release, it looks like BCR publishing is working smoothly. |
@fmeum (unless there is a way to rollback? i am open to your advice and will prepare the fix release but hold off until i hear) |
@sgammon If the 0.10.0 release in the BCR is (and always has been) broken, I think that we could make an exception and edit it. @meteorcloudy What do you think?. |
@fmeum it was the overlap of these two PRs, unfortunately, because I couldn't close the other one. the hash listed on i can also push a fix release as |
That's certainly the easiest solution. You can also try submitting a PR that just deletes the module, but yanking is cleaner. Sorry for the inconvenience! |
@fmeum All good, this release was feeling too quiet anyway 😆. I do have control over this PR, so I will push the fix via the PR bot since that is working smoothly now, tag you in it for review, and close this one. In that PR I will also yank this module. That should clean this up nicely and leave only one PR to merge 👍🏻 Thank you for your patience with me! EDIT: Just kidding, I will file a different PR to yank because I won't have control over that one. |
Yanking the broken one sounds fine to me! |
Summary
Adds rules_graalvm at the new release version of
0.10.0
.Inaugural features for BCR
native-image
native-image
on all OS targets (thank you @fmeum!)gu
--compilation_mode=opt
Usage
See project docs for the latest installation instructions.