Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(rules_diff): add 1.0.0-beta.2 #1881

Merged
merged 1 commit into from
May 2, 2024

Conversation

mattyclarkson
Copy link
Contributor

Apple Silicon support via [email protected].

@mattyclarkson mattyclarkson force-pushed the rules-diff-apple-silicon branch 3 times, most recently from ecc99be to 72d5dac Compare April 30, 2024 11:26
@mattyclarkson
Copy link
Contributor Author

mattyclarkson commented Apr 30, 2024

@fmeum would it be possible to get presubmit for this? Needed to unblock #1868 (rules_git)

@fmeum fmeum added the presubmit-auto-run Presubmit jobs will be triggered for new changes automatically without reviewer's approval label Apr 30, 2024
@mattyclarkson
Copy link
Contributor Author

I'm doing some remote execution fixes to bazel/ape that this will need to pick up.

I'll update this once those are ready.

@mattyclarkson
Copy link
Contributor Author

Needs #1926.

@mattyclarkson
Copy link
Contributor Author

Needs #1929.

Brings Apple Silicon and remote execution support.
@mattyclarkson mattyclarkson force-pushed the rules-diff-apple-silicon branch from 72d5dac to de7db9c Compare May 2, 2024 09:05
@mattyclarkson mattyclarkson changed the title feat(rules_diff): add 1.0.0-beta.1 feat(rules_diff): add 1.0.0-beta.2 May 2, 2024
@mattyclarkson
Copy link
Contributor Author

@fmeum this is ready. All checks passed on CI. Apple Silicon is good. I assume we have a BCR run that does remote execution. We've validated RE on our side though.

@fmeum fmeum merged commit ee96f84 into bazelbuild:main May 2, 2024
18 checks passed
@mattyclarkson mattyclarkson deleted the rules-diff-apple-silicon branch May 2, 2024 14:52
aiuto pushed a commit to aiuto/bazel-central-registry that referenced this pull request Jun 3, 2024
zaucy pushed a commit to zaucy/bazel-central-registry that referenced this pull request Jun 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
presubmit-auto-run Presubmit jobs will be triggered for new changes automatically without reviewer's approval
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants