Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gazelle: Populate plugins attributes with annotation processors #276

Merged
merged 5 commits into from
May 10, 2024

Conversation

illicitonion
Copy link
Collaborator

No description provided.

@illicitonion illicitonion force-pushed the annotation-processors branch from a8e904b to ee6fa59 Compare May 8, 2024 15:41
@illicitonion illicitonion enabled auto-merge (squash) May 8, 2024 15:55
@illicitonion illicitonion requested a review from stevebarrau May 8, 2024 15:59
This means we will properly handle inner classes, rather than
attributing annotations to outer classes even when they're on inner
classes.
The only error it returned was a never-happens error
Lints complain about these being different.
@illicitonion illicitonion force-pushed the annotation-processors branch from ee6fa59 to 8db45a8 Compare May 9, 2024 16:05
Copy link
Collaborator

@stevebarrau stevebarrau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @illicitonion. I see this being useful for things like auto (in your example), Lombok and many other compilation plugins.

@illicitonion illicitonion merged commit f6b2319 into bazel-contrib:main May 10, 2024
8 checks passed
@illicitonion illicitonion deleted the annotation-processors branch May 10, 2024 13:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants