Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix dependency on platforms #1263

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

allsey87
Copy link
Contributor

From #1262 (comment)

Its probably the non-bzlmod code path - we don't explicitly depend on platforms at the moment which I guess is a bug; you probably need to add platforms to the workspace macro in rules_foreign_cc/repositories.bzl too?

The goal of this PR is properly integrate platforms into rules_foreign_cc. Merging this will hopefully unblock #1262. I am setting this as a draft for now since I am a bit short on time to work on it and just want to see how CI behaves when I declare the repository.

@allsey87
Copy link
Contributor Author

Currently breaks CI with:

(15:29:29) ERROR: /workdir/test/BUILD.bazel:15:30: While resolving toolchains for target //test:shell_script_inner_fun (9a56767): No matching toolchains found for types //foreign_cc/private/framework:shell_toolchain.
To debug, rerun with --toolchain_resolution_debug='//foreign_cc/private/framework:shell_toolchain'

@allsey87
Copy link
Contributor Author

Any ideas/hints on how to solve this one, @jsharpe?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant